Protocol cleanup #374
Protocol cleanup #374
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -14,19 +14,9 @@ | |||
| #include "zenoh-pico/net/subscribe.h" | |||
|
|
|||
| #if Z_FEATURE_SUBSCRIPTION == 1 | |||
| _z_subinfo_t _z_subinfo_push_default(void) { | |||
| _z_subinfo_t _z_subinfo_default(void) { | |||
Check warning
Code scanning / Cppcheck (reported by Codacy)
misra violation 804 with no text in the supplied rule-texts-file Warning
| @@ -102,7 +102,7 @@ | |||
| return -1; | |||
| } | |||
|
|
|||
| printf("Enter any key to pull data or 'q' to quit...\n"); | |||
| printf("Enter any key to get data or 'q' to quit...\n"); | |||
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note
|
|
||
| z_undeclare_pull_subscriber(z_move(sub)); | ||
| // z_undeclare_pull_subscriber(z_move(sub)); | ||
| printf("Pull Subscriber not supported... exiting\n"); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note
|
|
||
| z_undeclare_pull_subscriber(z_move(sub)); | ||
| // z_undeclare_pull_subscriber(z_move(sub)); | ||
| printf("Pull Subscriber not supported... exiting\n"); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note
| @@ -67,7 +67,7 @@ | |||
| return -1; | |||
| } | |||
|
|
|||
| printf("Enter any key to pull data or 'q' to quit...\n"); | |||
| printf("Enter any key to get data or 'q' to quit...\n"); | |||
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note
|
@jean-roland could you please review it? |
|
|
||
| z_undeclare_pull_subscriber(z_move(sub)); | ||
| // z_undeclare_pull_subscriber(z_move(sub)); | ||
| printf("Pull Subscriber not supported... exiting\n"); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note
|
CI fails in the api alignment test: |
| @@ -380,9 +356,12 @@ | |||
| assert(!z_check(_ret_pub)); | |||
| printf("Ok\n"); | |||
|
|
|||
| printf("Undeclaring Pull Subscriber..."); | |||
| _ret_int8 = z_undeclare_pull_subscriber(z_move(_ret_psub)); | |||
| sleep(SLEEP); | |||
Check warning
Code scanning / Cppcheck (reported by Codacy)
sleep is MT-unsafe Warning test
| _ret_int8 = z_undeclare_pull_subscriber(z_move(_ret_psub)); | ||
| sleep(SLEEP); | ||
|
|
||
| printf("Undeclaring Subscriber..."); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note test
Remove unused or unimplemented behaviour.
Aligned with https://github.com/eclipse-zenoh/zenoh/tree/protocol_changes.